Fix pyright issue #30147 #30192
Open
Fix pyright issue #30147 #30192
+21
−38
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
linter failed, please fix |
mlukasze
requested changes
Apr 18, 2025
|
|
||
| if np_type: | ||
| return np.dtype(np_type) | ||
| # Sostituita implementazione con next() per evitare None |
There was a problem hiding this comment.
comments, if necessary, should be in english, please
|
|
||
| if np_type: | ||
| return np_type | ||
| # Sostituita implementazione con next() per evitare None |
|
|
||
| raise OVTypeError("Unidentified data type %s", openvino_type) | ||
|
|
||
|
|
||
| def get_ndarray(data: NumericData) -> np.ndarray: | ||
| """Wrap data into a numpy ndarray.""" | ||
| if isinstance(data, np.ndarray): | ||
| return data # type: ignore | ||
| return data |
| return np.array(data) | ||
|
|
||
|
|
||
| def get_shape(data: NumericData) -> TensorShape: | ||
| """Return a shape of NumericData.""" | ||
| if isinstance(data, np.ndarray): | ||
| return data.shape # type: ignore | ||
| return data.shape |
| if isinstance(data, list): | ||
| return [len(data)] # type: ignore | ||
| return [len(data)] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issue #30147 by resolving the Pyright errors in the
src/openvino/utils/types.pyfile.Changes made
castimport from the typing libraryas_nodefunction to use proper type casting withisinstancechecks instead ofissubclass(type())as_nodesfunction usingcastfor proper list typingTesting
src/openvino/utils/types.pyfrom the exclusions inpyproject.toml